chore: Enable SSE only for authenticated users #973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. |
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report vs. main branch |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/inapp-sse #973 +/- ##
====================================================
Coverage ? 68.20%
====================================================
Files ? 182
Lines ? 9400
Branches ? 0
====================================================
Hits ? 6411
Misses ? 2989
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // logger.logWithModuleTag("State changes after action '\(action)': \(changes)", level: .debug) | ||
| } else { | ||
| logger.logWithModuleTag("No state changes after action '\(action)'", level: .debug) | ||
| // logger.logWithModuleTag("No state changes after action '\(action)'", level: .debug) |
There was a problem hiding this comment.
Commented out logging statements appear accidentally committed
Three debug logging statements in inAppMessageReducer have been commented out rather than removed. The PR title mentions enabling SSE only for authenticated users, not disabling logging. The function's docstring still states it "logs the action and state before and after the reducer is called" but the actual logging is now disabled, creating inconsistency. Other debug logging throughout the codebase remains active, suggesting these were temporarily disabled during development and accidentally committed.
mahmoud-elmorabea
force-pushed
the
sse-lifecycle
branch
from
32a1c68 to
9d6c72d
Compare
mahmoud-elmorabea
force-pushed
the
sse-auth-users-only
branch
from
504250f to
8672ff8
Compare
mahmoud-elmorabea
force-pushed
the
sse-lifecycle
branch
from
9d6c72d to
8bec6ac
Compare
mahmoud-elmorabea
force-pushed
the
sse-auth-users-only
branch
2 times, most recently
from
c797f69 to
158290e
Compare
Shahroz16
approved these changes
Dec 29, 2025
| // logger.logWithModuleTag("State changes after action '\(action)': \(changes)", level: .debug) | ||
| } else { | ||
| logger.logWithModuleTag("No state changes after action '\(action)'", level: .debug) | ||
| // logger.logWithModuleTag("No state changes after action '\(action)'", level: .debug) |
mahmoud-elmorabea
force-pushed
the
sse-auth-users-only
branch
from
158290e to
097c09b
Compare
mrehan27
approved these changes
Jan 1, 2026
mahmoud-elmorabea
force-pushed
the
sse-auth-users-only
branch
from
097c09b to
618301f
Compare
mahmoud-elmorabea
force-pushed
the
sse-auth-users-only
branch
from
618301f to
5bf1ff9
Compare
mahmoud-elmorabea
added a commit
that referenced
this pull request
Jan 5, 2026
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that SSE connections are only enabled for authenticated users and not anonymous users.
Note
Aligns SSE usage with eligibility rules and streamlines polling control.
InAppMessageState.isUserIdentifiedandshouldUseSseto centralize SSE eligibilityGistto subscribe topollInterval,useSse, anduserId; start/stop polling based onshouldUseSseand user identification; skip polling when SSE is activeSseLifecycleManagerto also subscribe touserId, check eligibility before starting SSE, and always stop SSE on background; refine foreground/background and flag change handling to avoid racesSseLifecycleManagerTestto cover anonymous vs identified users, foreground/background transitions, SSE flag changes, and combined flowsWritten by Cursor Bugbot for commit 5bf1ff9. This will update automatically on new commits. Configure here.